hotfix: ranking#675
Merged
Merged
Conversation
chaeyn
approved these changes
Apr 14, 2026
redjungi09
approved these changes
Apr 14, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the experience thresholds for the Aura, Master, and Diamond tiers within the ranking service and domain enums, and updates the associated unit tests. The feedback recommends correcting the Javadoc in RankingTierUpdateService to accurately reflect that the Master tier is applicable to users ranked 1st through 3rd, aligning the documentation with the existing code logic.
| * - Aura : 1위 && exp >= 100,000 | ||
| * - Master: 2~3위 && exp >= 75,000 (상위 3등 2명) | ||
| * - Aura : 1위 && exp >= 200,000 | ||
| * - Master: 2~3위 && exp >= 150,000 (상위 3등 2명) |
Contributor
There was a problem hiding this comment.
Master 티어의 조건 설명이 실제 코드 로직과 차이가 있습니다. 코드(93라인)에서는 rank <= 3을 확인하므로, 1위 유저가 AURA 점수 기준(200,000)을 충족하지 못하더라도 MASTER 점수 기준(150,000)을 충족하면 MASTER 티어를 부여받게 됩니다. 주석의 2~3위 및 (상위 3등 2명) 문구를 1~3위 또는 상위 3위로 수정하여 실제 동작과 일치시키는 것이 좋습니다.
Suggested change
| * - Master: 2~3위 && exp >= 150,000 (상위 3등 2명) | |
| * - Master: 1~3위 && exp >= 150,000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경사항
다이아 10만점
마스터 15만점
아우라 20만점
관련 이슈
Closes #
추가 컨텍스트